Unverified Commit 08411e34 authored by Qing Wang's avatar Qing Wang Committed by Mark Brown
Browse files

spi: replace snprintf in show functions with sysfs_emit



show() must not use snprintf() when formatting the value to be
returned to user space.

Fix the following coccicheck warning:
drivers/spi/spi-tle62x0.c:144: WARNING: use scnprintf or sprintf.

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Signed-off-by: default avatarQing Wang <wangqing@vivo.com>
Link: https://lore.kernel.org/r/1634280668-4954-1-git-send-email-wangqing@vivo.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 2a4a4e89
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -141,7 +141,7 @@ static ssize_t tle62x0_gpio_show(struct device *dev,
	value = (st->gpio_state >> gpio_num) & 1;
	mutex_unlock(&st->lock);

	return snprintf(buf, PAGE_SIZE, "%d", value);
	return sysfs_emit(buf, "%d", value);
}

static ssize_t tle62x0_gpio_store(struct device *dev,