Commit 0840c9f7 authored by Paul Blakey's avatar Paul Blakey Committed by Saeed Mahameed
Browse files

net/mlx5e: Set default can_offload action 



Many parsers of tc actions just return true on their can_offload()
implementation, without checking the input flow/action.
Set the default can_offload action to true (allow), and avoid
having many can_offload implementations that do just that.

This patch doesn't change any functionality.

Signed-off-by: default avatarPaul Blakey <paulb@nvidia.com>
Reviewed-by: default avatarRoi Dayan <roid@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 8b0f2565

drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/accept.c

+0 −10
Original line number Diff line number Diff line
@@ -4,15 +4,6 @@ 
#include "act.h"

#include "en/tc_priv.h"



static bool

tc_act_can_offload_accept(struct mlx5e_tc_act_parse_state *parse_state,

			  const struct flow_action_entry *act,

			  int act_index,

			  struct mlx5_flow_attr *attr)

{

	return true;

}



static int

tc_act_parse_accept(struct mlx5e_tc_act_parse_state *parse_state,

		    const struct flow_action_entry *act,
@@ -26,7 +17,6 @@ tc_act_parse_accept(struct mlx5e_tc_act_parse_state *parse_state, 
}



struct mlx5e_tc_act mlx5e_tc_act_accept = {

	.can_offload = tc_act_can_offload_accept,

	.parse_action = tc_act_parse_accept,

	.is_terminating_action = true,

};

drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/drop.c

+0 −10
Original line number Diff line number Diff line
@@ -4,15 +4,6 @@ 
#include "act.h"

#include "en/tc_priv.h"



static bool

tc_act_can_offload_drop(struct mlx5e_tc_act_parse_state *parse_state,

			const struct flow_action_entry *act,

			int act_index,

			struct mlx5_flow_attr *attr)

{

	return true;

}



static int

tc_act_parse_drop(struct mlx5e_tc_act_parse_state *parse_state,

		  const struct flow_action_entry *act,
@@ -25,7 +16,6 @@ tc_act_parse_drop(struct mlx5e_tc_act_parse_state *parse_state, 
}



struct mlx5e_tc_act mlx5e_tc_act_drop = {

	.can_offload = tc_act_can_offload_drop,

	.parse_action = tc_act_parse_drop,

	.is_terminating_action = true,

};

drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/pedit.c

+0 −10
Original line number Diff line number Diff line
@@ -78,15 +78,6 @@ mlx5e_tc_act_pedit_parse_action(struct mlx5e_priv *priv, 
	return err;

}



static bool

tc_act_can_offload_pedit(struct mlx5e_tc_act_parse_state *parse_state,

			 const struct flow_action_entry *act,

			 int act_index,

			 struct mlx5_flow_attr *attr)

{

	return true;

}



static int

tc_act_parse_pedit(struct mlx5e_tc_act_parse_state *parse_state,

		   const struct flow_action_entry *act,
@@ -114,6 +105,5 @@ tc_act_parse_pedit(struct mlx5e_tc_act_parse_state *parse_state, 
}



struct mlx5e_tc_act mlx5e_tc_act_pedit = {

	.can_offload = tc_act_can_offload_pedit,

	.parse_action = tc_act_parse_pedit,

};

drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/ptype.c

+0 −10
Original line number Diff line number Diff line
@@ -4,15 +4,6 @@ 
#include "act.h"

#include "en/tc_priv.h"



static bool

tc_act_can_offload_ptype(struct mlx5e_tc_act_parse_state *parse_state,

			 const struct flow_action_entry *act,

			 int act_index,

			 struct mlx5_flow_attr *attr)

{

	return true;

}



static int

tc_act_parse_ptype(struct mlx5e_tc_act_parse_state *parse_state,

		   const struct flow_action_entry *act,
@@ -31,6 +22,5 @@ tc_act_parse_ptype(struct mlx5e_tc_act_parse_state *parse_state, 
}



struct mlx5e_tc_act mlx5e_tc_act_ptype = {

	.can_offload = tc_act_can_offload_ptype,

	.parse_action = tc_act_parse_ptype,

};

drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/trap.c

+0 −10
Original line number Diff line number Diff line
@@ -5,15 +5,6 @@ 
#include "en/tc_priv.h"

#include "eswitch.h"



static bool

tc_act_can_offload_trap(struct mlx5e_tc_act_parse_state *parse_state,

			const struct flow_action_entry *act,

			int act_index,

			struct mlx5_flow_attr *attr)

{

	return true;

}



static int

tc_act_parse_trap(struct mlx5e_tc_act_parse_state *parse_state,

		  const struct flow_action_entry *act,
@@ -27,6 +18,5 @@ tc_act_parse_trap(struct mlx5e_tc_act_parse_state *parse_state, 
}



struct mlx5e_tc_act mlx5e_tc_act_trap = {

	.can_offload = tc_act_can_offload_trap,

	.parse_action = tc_act_parse_trap,

};