Commit 081172a1 authored by Michael Tretter's avatar Michael Tretter Committed by Mauro Carvalho Chehab
Browse files

media: allegro: remove unknown39 field from create_channel 



The subframe_latency and lda_control_mode fields directly follow
freq_golden_ref field and there is no unknown field in between. The
unknown field it at the end of the message.

Reorder the fields accordingly. This further allows to drop the hard
coded value from the lda_control_mode field and set the mode to 0.

Signed-off-by: default avatarMichael Tretter <m.tretter@pengutronix.de>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 82778153

drivers/staging/media/allegro-dvt/allegro-core.c

+1 −3
Original line number Diff line number Diff line
@@ -397,10 +397,9 @@ struct mcu_msg_create_channel { 
	u8 num_b;

	u8 freq_golden_ref;



	u32 unknown39;



	u32 subframe_latency;

	u32 lda_control_mode;

	u32 unknown41;

} __attribute__ ((__packed__));



struct mcu_msg_create_channel_response {
@@ -1121,7 +1120,6 @@ static int allegro_mcu_send_create_channel(struct allegro_dev *dev, 
	msg.gdr_mode = 0x00000000;

	msg.gop_length = channel->gop_size;

	msg.subframe_latency = 0x00000000;

	msg.lda_control_mode = 0x700d0000;



	allegro_mbox_write(dev, &dev->mbox_command, &msg, sizeof(msg));

	allegro_mcu_interrupt(dev);