Commit 07e61a97 authored by Ido Schimmel's avatar Ido Schimmel Committed by Jakub Kicinski
Browse files

nexthop: Fix off-by-one error in error path 



A reference was not taken for the current nexthop entry, so do not try
to put it in the error path.

Fixes: 430a0491 ("nexthop: Add support for nexthop groups")
Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
Reviewed-by: default avatarDavid Ahern <dsahern@kernel.org>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ac7996d6

net/ipv4/nexthop.c

+1 −1
Original line number Diff line number Diff line
@@ -1459,7 +1459,7 @@ static struct nexthop *nexthop_create_group(struct net *net, 
	return nh;



out_no_nh:

	for (; i >= 0; --i)

	for (i--; i >= 0; --i)

		nexthop_put(nhg->nh_entries[i].nh);



	kfree(nhg->spare);