Commit 07be39e3 authored by Grzegorz Siwik's avatar Grzegorz Siwik Committed by Tony Nguyen
Browse files

igb: Add counter to i21x doublecheck 



Add failed_counter to i21x_doublecheck(). There is possibility that
loop will never end.
With this patch the loop will stop after maximum 3 retries
to write to MTA_REGISTER

Signed-off-by: default avatarGrzegorz Siwik <grzegorz.siwik@intel.com>
Tested-by: default avatarTony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 356ae88f

drivers/net/ethernet/intel/igb/e1000_mac.c

+5 −1
Original line number Diff line number Diff line
@@ -492,6 +492,7 @@ static u32 igb_hash_mc_addr(struct e1000_hw *hw, u8 *mc_addr) 
 **/

static void igb_i21x_hw_doublecheck(struct e1000_hw *hw)

{

	int failed_cnt = 3;

	bool is_failed;

	int i;
@@ -502,9 +503,12 @@ static void igb_i21x_hw_doublecheck(struct e1000_hw *hw) 
				is_failed = true;

				array_wr32(E1000_MTA, i, hw->mac.mta_shadow[i]);

				wrfl();

				break;

			}

		}

		if (is_failed && --failed_cnt <= 0) {

			hw_dbg("Failed to update MTA_REGISTER, too many retries");

			break;

		}

	} while (is_failed);

}