Commit 0755d3be authored by Maurizio Lombardi's avatar Maurizio Lombardi Committed by Christoph Hellwig
Browse files

nvme-tcp: can't set sk_user_data without write_lock 



The sk_user_data pointer is supposed to be modified only while
holding the write_lock "sk_callback_lock", otherwise
we could race with other threads and crash the kernel.

we can't take the write_lock in nvmet_tcp_state_change()
because it would cause a deadlock, but the release_work queue
will set the pointer to NULL later so we can simply remove
the assignment.

Fixes: b5332a9f ("nvmet-tcp: fix incorrect locking in state_change sk callback")

Signed-off-by: default avatarMaurizio Lombardi <mlombard@redhat.com>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 585af8ed

drivers/nvme/target/tcp.c

+0 −1
Original line number Diff line number Diff line
@@ -1497,7 +1497,6 @@ static void nvmet_tcp_state_change(struct sock *sk) 
	case TCP_CLOSE_WAIT:

	case TCP_CLOSE:

		/* FALLTHRU */

		sk->sk_user_data = NULL;

		nvmet_tcp_schedule_release_queue(queue);

		break;

	default: