Commit 06f45435 authored by Takashi Sakamoto's avatar Takashi Sakamoto
Browse files

firewire: core: obsolete usage of GFP_ATOMIC at building node tree 

The flag of GFP_ATOMIC is given to the call of kmalloc when building node
tree, but the call is not atomic context. The call of
fw_core_handle_bus_reset() and fw_core_remove_card() builds the tree,
while they are done in specific workqueue or pci remove callback.

This commit obsolete the usage of GFP_ATOMIC.

Link: https://lore.kernel.org/r/20230604070255.172700-1-o-takashi@sakamocchi.jp


Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
parent 5716e58a

drivers/firewire/core-device.c

+1 −1
Original line number Diff line number Diff line
@@ -1211,7 +1211,7 @@ void fw_node_event(struct fw_card *card, struct fw_node *node, int event) 
		 * without actually having a link.

		 */

 create:

		device = kzalloc(sizeof(*device), GFP_ATOMIC);

		device = kzalloc(sizeof(*device), GFP_KERNEL);

		if (device == NULL)

			break;

drivers/firewire/core-topology.c

+1 −1
Original line number Diff line number Diff line
@@ -101,7 +101,7 @@ static struct fw_node *fw_node_create(u32 sid, int port_count, int color) 
{

	struct fw_node *node;



	node = kzalloc(struct_size(node, ports, port_count), GFP_ATOMIC);

	node = kzalloc(struct_size(node, ports, port_count), GFP_KERNEL);

	if (node == NULL)

		return NULL;