Commit 0668e8cc authored by Yang Yingliang's avatar Yang Yingliang Committed by Thierry Reding
Browse files

hte: Fix possible use-after-free in tegra_hte_test_remove() 



del_timer() does not wait until the timer handler finishing.
This means that the timer handler may still be running after
the driver's remove function has finished, which would result
in a use-after-free.
Fix it by calling del_timer_sync(), which makes sure the timer
handler has finished.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarDipen Patel <dipenp@nvidia.com>
Acked-by: default avatarDipen Patel <dipenp@nvidia.com>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent e0bfb57e

drivers/hte/hte-tegra194-test.c

+1 −1
Original line number Diff line number Diff line
@@ -219,7 +219,7 @@ static int tegra_hte_test_remove(struct platform_device *pdev) 
	free_irq(hte.gpio_in_irq, &hte);

	gpiod_put(hte.gpio_in);

	gpiod_put(hte.gpio_out);

	del_timer(&hte.timer);

	del_timer_sync(&hte.timer);



	return 0;

}