Commit 06634d5b authored by Zheyu Ma's avatar Zheyu Ma Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Return -ENOMEM if kzalloc() fails 

The driver probing function should return < 0 for failure, otherwise
kernel will treat value > 0 as success.

Link: https://lore.kernel.org/r/1634522181-31166-1-git-send-email-zheyuma97@gmail.com


Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: default avatarZheyu Ma <zheyuma97@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 85374b63

drivers/scsi/qla2xxx/qla_os.c

+1 −1
Original line number Diff line number Diff line
@@ -4157,7 +4157,7 @@ qla2x00_mem_alloc(struct qla_hw_data *ha, uint16_t req_len, uint16_t rsp_len, 
					ql_dbg_pci(ql_dbg_init, ha->pdev,

					    0xe0ee, "%s: failed alloc dsd\n",

					    __func__);

					return 1;

					return -ENOMEM;

				}

				ha->dif_bundle_kallocs++;