Commit 0659400f authored by Luka Guzenko's avatar Luka Guzenko Committed by Takashi Iwai
Browse files

ALSA: hda/realtek: Enable Mute LED on HP Laptop 15s-eq2xxx 



The HP Laptop 15s-eq2xxx uses ALC236 codec and controls the mute LED using
COEF 0x07 index 1. No existing quirk covers this configuration.
Adds a new quirk and enables it for the device.

Signed-off-by: default avatarLuka Guzenko <l.guzenko@web.de>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20230718161241.393181-1-l.guzenko@web.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent a2a93f4e

sound/pci/hda/patch_realtek.c

+21 −0
Original line number Diff line number Diff line
@@ -4624,6 +4624,21 @@ static void alc236_fixup_hp_mute_led_coefbit(struct hda_codec *codec, 
	}

}



static void alc236_fixup_hp_mute_led_coefbit2(struct hda_codec *codec,

					  const struct hda_fixup *fix, int action)

{

	struct alc_spec *spec = codec->spec;



	if (action == HDA_FIXUP_ACT_PRE_PROBE) {

		spec->mute_led_polarity = 0;

		spec->mute_led_coef.idx = 0x07;

		spec->mute_led_coef.mask = 1;

		spec->mute_led_coef.on = 1;

		spec->mute_led_coef.off = 0;

		snd_hda_gen_add_mute_led_cdev(codec, coef_mute_led_set);

	}

}



/* turn on/off mic-mute LED per capture hook by coef bit */

static int coef_micmute_led_set(struct led_classdev *led_cdev,

				enum led_brightness brightness)
@@ -7144,6 +7159,7 @@ enum { 
	ALC285_FIXUP_HP_GPIO_LED,

	ALC285_FIXUP_HP_MUTE_LED,

	ALC285_FIXUP_HP_SPECTRE_X360_MUTE_LED,

	ALC236_FIXUP_HP_MUTE_LED_COEFBIT2,

	ALC236_FIXUP_HP_GPIO_LED,

	ALC236_FIXUP_HP_MUTE_LED,

	ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF,
@@ -8633,6 +8649,10 @@ static const struct hda_fixup alc269_fixups[] = { 
		.type = HDA_FIXUP_FUNC,

		.v.func = alc285_fixup_hp_spectre_x360_mute_led,

	},

	[ALC236_FIXUP_HP_MUTE_LED_COEFBIT2] = {

	    .type = HDA_FIXUP_FUNC,

	    .v.func = alc236_fixup_hp_mute_led_coefbit2,

	},

	[ALC236_FIXUP_HP_GPIO_LED] = {

		.type = HDA_FIXUP_FUNC,

		.v.func = alc236_fixup_hp_gpio_led,
@@ -9517,6 +9537,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { 
	SND_PCI_QUIRK(0x103c, 0x886d, "HP ZBook Fury 17.3 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),

	SND_PCI_QUIRK(0x103c, 0x8870, "HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),

	SND_PCI_QUIRK(0x103c, 0x8873, "HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),

	SND_PCI_QUIRK(0x103c, 0x887a, "HP Laptop 15s-eq2xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),

	SND_PCI_QUIRK(0x103c, 0x888d, "HP ZBook Power 15.6 inch G8 Mobile Workstation PC", ALC236_FIXUP_HP_GPIO_LED),

	SND_PCI_QUIRK(0x103c, 0x8895, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_SPEAKERS_MICMUTE_LED),

	SND_PCI_QUIRK(0x103c, 0x8896, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_MUTE_LED),