Commit 064109db authored by ChenXiaoSong's avatar ChenXiaoSong Committed by Trond Myklebust
Browse files

NFS: remove redundant code in nfs_file_write() 



filemap_fdatawait_range() will always return 0, after patch 6c984083
("NFS: Use of mapping_set_error() results in spurious errors"), it will not
save the wb err in struct address_space->flags:

  result = filemap_fdatawait_range(file->f_mapping, ...) = 0
    filemap_check_errors(mapping) = 0
      test_bit(..., &mapping->flags) // flags is 0

Signed-off-by: default avatarChenXiaoSong <chenxiaosong2@huawei.com>
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent f931d837

fs/nfs/file.c

+0 −2
Original line number Diff line number Diff line
@@ -663,8 +663,6 @@ ssize_t nfs_file_write(struct kiocb *iocb, struct iov_iter *from) 
		result = filemap_fdatawait_range(file->f_mapping,

						 iocb->ki_pos - written,

						 iocb->ki_pos - 1);

		if (result < 0)

			goto out;

	}

	result = generic_write_sync(iocb, written);

	if (result < 0)