Commit 06354900 authored by zgpeng's avatar zgpeng Committed by Peter Zijlstra
Browse files

sched/fair: Move calculate of avg_load to a better location 



In calculate_imbalance function, when the value of local->avg_load is
greater than or equal to busiest->avg_load, the calculated sds->avg_load is
not used. So this calculation can be placed in a more appropriate position.

Signed-off-by: default avatarzgpeng <zgpeng@tencent.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarSamuel Liao <samuelliao@tencent.com>
Reviewed-by: default avatarVincent Guittot <vincent.guittot@linaro.org>
Link: https://lore.kernel.org/r/1649239025-10010-1-git-send-email-zgpeng@tencent.com
parent e3f73ece

kernel/sched/fair.c

+3 −2
Original line number Diff line number Diff line
@@ -9460,8 +9460,6 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s 
		local->avg_load = (local->group_load * SCHED_CAPACITY_SCALE) /

				  local->group_capacity;



		sds->avg_load = (sds->total_load * SCHED_CAPACITY_SCALE) /

				sds->total_capacity;

		/*

		 * If the local group is more loaded than the selected

		 * busiest group don't try to pull any tasks.
@@ -9470,6 +9468,9 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s 
			env->imbalance = 0;

			return;

		}



		sds->avg_load = (sds->total_load * SCHED_CAPACITY_SCALE) /

				sds->total_capacity;

	}



	/*