Unverified Commit 062fa09f authored by Dinghao Liu's avatar Dinghao Liu Committed by Mark Brown
Browse files

ASoC: intel: Fix memleak in sst_media_open 



When power_up_sst() fails, stream needs to be freed
just like when try_module_get() fails. However, current
code is returning directly and ends up leaking memory.

Fixes: 0121327c ("ASoC: Intel: mfld-pcm: add control for powering up/down dsp")
Signed-off-by: default avatarDinghao Liu <dinghao.liu@zju.edu.cn>
Acked-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200813084112.26205-1-dinghao.liu@zju.edu.cn


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f082bb59

sound/soc/intel/atom/sst-mfld-platform-pcm.c

+3 −2
Original line number Diff line number Diff line
@@ -331,7 +331,7 @@ static int sst_media_open(struct snd_pcm_substream *substream, 


	ret_val = power_up_sst(stream);

	if (ret_val < 0)

		return ret_val;

		goto out_power_up;



	/* Make sure, that the period size is always even */

	snd_pcm_hw_constraint_step(substream->runtime, 0,
@@ -340,8 +340,9 @@ static int sst_media_open(struct snd_pcm_substream *substream, 
	return snd_pcm_hw_constraint_integer(runtime,

			 SNDRV_PCM_HW_PARAM_PERIODS);

out_ops:

	kfree(stream);

	mutex_unlock(&sst_lock);

out_power_up:

	kfree(stream);

	return ret_val;

}