Commit 062c9cdf authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Linus Torvalds
Browse files

pwm: sl28cpld: fix getting driver data in pwm callbacks 



Currently .get_state() and .apply() use dev_get_drvdata() on the struct
device related to the pwm chip.  This only works after .probe() called
platform_set_drvdata() which in this driver happens only after
pwmchip_add() and so comes possibly too late.

Instead of setting the driver data earlier use the traditional
container_of approach as this way the driver data is conceptually and
computational nearer.

Fixes: 9db33d22 ("pwm: Add support for sl28cpld PWM controller")
Tested-by: default avatarMichael Walle <michael@walle.cc>
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 4f134b89

drivers/pwm/pwm-sl28cpld.c

+4 −2
Original line number Diff line number Diff line
@@ -84,12 +84,14 @@ struct sl28cpld_pwm { 
	struct regmap *regmap;

	u32 offset;

};

#define sl28cpld_pwm_from_chip(_chip) \

	container_of(_chip, struct sl28cpld_pwm, pwm_chip)



static void sl28cpld_pwm_get_state(struct pwm_chip *chip,

				   struct pwm_device *pwm,

				   struct pwm_state *state)

{

	struct sl28cpld_pwm *priv = dev_get_drvdata(chip->dev);

	struct sl28cpld_pwm *priv = sl28cpld_pwm_from_chip(chip);

	unsigned int reg;

	int prescaler;
@@ -118,7 +120,7 @@ static void sl28cpld_pwm_get_state(struct pwm_chip *chip, 
static int sl28cpld_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,

			      const struct pwm_state *state)

{

	struct sl28cpld_pwm *priv = dev_get_drvdata(chip->dev);

	struct sl28cpld_pwm *priv = sl28cpld_pwm_from_chip(chip);

	unsigned int cycle, prescaler;

	bool write_duty_cycle_first;

	int ret;