Commit 06285da9 authored Jun 21, 2021 by Paolo Abeni Committed by David S. Miller Jun 22, 2021

mptcp: add MIB counter for invalid mapping



Account this exceptional events for better introspection.

Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8cfc47fc

net/mptcp/mib.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -25,6 +25,7 @@ static const struct snmp_mib mptcp_snmp_list[] = {
		SNMP_MIB_ITEM("MPJoinAckHMacFailure", MPTCP_MIB_JOINACKMAC),
		SNMP_MIB_ITEM("DSSNotMatching", MPTCP_MIB_DSSNOMATCH),
		SNMP_MIB_ITEM("InfiniteMapRx", MPTCP_MIB_INFINITEMAPRX),
		SNMP_MIB_ITEM("DSSNoMatchTCP", MPTCP_MIB_DSSTCPMISMATCH),
		SNMP_MIB_ITEM("DataCsumErr", MPTCP_MIB_DATACSUMERR),
		SNMP_MIB_ITEM("OFOQueueTail", MPTCP_MIB_OFOQUEUETAIL),
		SNMP_MIB_ITEM("OFOQueue", MPTCP_MIB_OFOQUEUE),

net/mptcp/mib.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -18,6 +18,7 @@ enum linux_mptcp_mib_field {
		MPTCP_MIB_JOINACKMAC, /* HMAC was wrong on ACK + MP_JOIN */
		MPTCP_MIB_DSSNOMATCH, /* Received a new mapping that did not match the previous one */
		MPTCP_MIB_INFINITEMAPRX, /* Received an infinite mapping */
		MPTCP_MIB_DSSTCPMISMATCH, /* DSS-mapping did not map with TCP's sequence numbers */
		MPTCP_MIB_DATACSUMERR, /* The data checksum fail */
		MPTCP_MIB_OFOQUEUETAIL, /* Segments inserted into OoO queue tail */
		MPTCP_MIB_OFOQUEUE, /* Segments inserted into OoO queue */

net/mptcp/subflow.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1046,8 +1046,10 @@ static enum mapping_status get_mapping_status(struct sock *ssk,
		/* we revalidate valid mapping on new skb, because we must ensure
		* the current skb is completely covered by the available mapping
		*/
		if (!validate_mapping(ssk, skb))
		if (!validate_mapping(ssk, skb)) {
		MPTCP_INC_STATS(sock_net(ssk), MPTCP_MIB_DSSTCPMISMATCH);
		return MAPPING_INVALID;
		}

		skb_ext_del(skb, SKB_EXT_MPTCP);