Commit 05f929b3 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

serial: liteuart: fix use-after-free and memleak on unbind 



Deregister the port when unbinding the driver to prevent it from being
used after releasing the driver data and leaking memory allocated by
serial core.

Fixes: 1da81e55 ("drivers/tty/serial: add LiteUART driver")
Cc: stable@vger.kernel.org      # 5.11
Cc: Filip Kokosinski <fkokosinski@antmicro.com>
Cc: Mateusz Holenko <mholenko@antmicro.com>
Reviewed-by: default avatarStafford Horne <shorne@gmail.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20211117100512.5058-2-johan@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0f55f89d

drivers/tty/serial/liteuart.c

+1 −0
Original line number Diff line number Diff line
@@ -295,6 +295,7 @@ static int liteuart_remove(struct platform_device *pdev) 
	struct uart_port *port = platform_get_drvdata(pdev);

	struct liteuart_port *uart = to_liteuart_port(port);



	uart_remove_one_port(&liteuart_driver, port);

	xa_erase(&liteuart_array, uart->id);



	return 0;