Commit 05d00135 authored by Vinod Polimera's avatar Vinod Polimera Committed by Dmitry Baryshkov
Browse files

drm/msm/dp: use the eDP bridge ops to validate eDP modes 



The eDP and DP interfaces shared the bridge operations and
the eDP specific changes were implemented under is_edp check.
To add psr support for eDP, we started using a new set of eDP
bridge ops. We are moving the eDP specific code in the
dp_bridge_mode_valid function to a new eDP function,
edp_bridge_mode_valid under the eDP bridge ops.

Signed-off-by: default avatarSankeerth Billakanti <quic_sbillaka@quicinc.com>
Signed-off-by: default avatarVinod Polimera <quic_vpolimer@quicinc.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/524736/
Link: https://lore.kernel.org/r/1677774797-31063-11-git-send-email-quic_vpolimer@quicinc.com


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent cd779808

drivers/gpu/drm/msm/dp/dp_display.c

+0 −8
Original line number Diff line number Diff line
@@ -996,14 +996,6 @@ enum drm_mode_status dp_bridge_mode_valid(struct drm_bridge *bridge, 
		return -EINVAL;

	}



	/*

	 * The eDP controller currently does not have a reliable way of

	 * enabling panel power to read sink capabilities. So, we rely

	 * on the panel driver to populate only supported modes for now.

	 */

	if (dp->is_edp)

		return MODE_OK;



	if (mode->clock > DP_MAX_PIXEL_CLK_KHZ)

		return MODE_CLOCK_HIGH;

drivers/gpu/drm/msm/dp/dp_drm.c

+33 −1
Original line number Diff line number Diff line
@@ -226,12 +226,44 @@ static void edp_bridge_atomic_post_disable(struct drm_bridge *drm_bridge, 
	dp_bridge_atomic_post_disable(drm_bridge, old_bridge_state);

}



/**

 * edp_bridge_mode_valid - callback to determine if specified mode is valid

 * @bridge: Pointer to drm bridge structure

 * @info: display info

 * @mode: Pointer to drm mode structure

 * Returns: Validity status for specified mode

 */

static enum drm_mode_status edp_bridge_mode_valid(struct drm_bridge *bridge,

					  const struct drm_display_info *info,

					  const struct drm_display_mode *mode)

{

	struct msm_dp *dp;

	int mode_pclk_khz = mode->clock;



	dp = to_dp_bridge(bridge)->dp_display;



	if (!dp || !mode_pclk_khz || !dp->connector) {

		DRM_ERROR("invalid params\n");

		return -EINVAL;

	}



	if (mode->clock > DP_MAX_PIXEL_CLK_KHZ)

		return MODE_CLOCK_HIGH;



	/*

	 * The eDP controller currently does not have a reliable way of

	 * enabling panel power to read sink capabilities. So, we rely

	 * on the panel driver to populate only supported modes for now.

	 */

	return MODE_OK;

}



static const struct drm_bridge_funcs edp_bridge_ops = {

	.atomic_enable = edp_bridge_atomic_enable,

	.atomic_disable = edp_bridge_atomic_disable,

	.atomic_post_disable = edp_bridge_atomic_post_disable,

	.mode_set = dp_bridge_mode_set,

	.mode_valid = dp_bridge_mode_valid,

	.mode_valid = edp_bridge_mode_valid,

	.atomic_reset = drm_atomic_helper_bridge_reset,

	.atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,

	.atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,