Commit 05a444d3 authored by Colin Ian King's avatar Colin Ian King Committed by Ilya Dryomov
Browse files

ceph: fix dereference of null pointer cf 



Currently in the case where kmem_cache_alloc fails the null pointer
cf is dereferenced when assigning cf->is_capsnap = false. Fix this
by adding a null pointer check and return path.

Cc: stable@vger.kernel.org
Addresses-Coverity: ("Dereference null return")
Fixes: b2f9fa1f ("ceph: correctly handle releasing an embedded cap flush")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarIlya Dryomov <idryomov@gmail.com>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
parent 9f358999

fs/ceph/caps.c

+3 −0
Original line number Diff line number Diff line
@@ -1736,6 +1736,9 @@ struct ceph_cap_flush *ceph_alloc_cap_flush(void) 
	struct ceph_cap_flush *cf;



	cf = kmem_cache_alloc(ceph_cap_flush_cachep, GFP_KERNEL);

	if (!cf)

		return NULL;



	cf->is_capsnap = false;

	return cf;

}