Commit 0593ad21 authored by Philip Yang's avatar Philip Yang Committed by Alex Deucher
Browse files

drm/amdkfd: Correct mmu_notifier_get failure handling 



If process has signal pending, mmu_notifier_get_locked fails and calls
ops->free_notifier, kfd_process_free_notifier will schedule
kfd_process_wq_release as process refcount is 1, but process structure
is already freed. This use after free bug causes system crash with
different backtrace.

The fix is to increase process refcount and then decrease the refcount
after mmu_notifier_get success.

Signed-off-by: default avatarPhilip Yang <Philip.Yang@amd.com>
Reviewed-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 1c05d9e5

drivers/gpu/drm/amd/amdkfd/kfd_process.c

+6 −0
Original line number Diff line number Diff line
@@ -1405,6 +1405,11 @@ static struct kfd_process *create_process(const struct task_struct *thread) 
	hash_add_rcu(kfd_processes_table, &process->kfd_processes,

			(uintptr_t)process->mm);



	/* Avoid free_notifier to start kfd_process_wq_release if

	 * mmu_notifier_get failed because of pending signal.

	 */

	kref_get(&process->ref);



	/* MMU notifier registration must be the last call that can fail

	 * because after this point we cannot unwind the process creation.

	 * After this point, mmu_notifier_put will trigger the cleanup by
@@ -1417,6 +1422,7 @@ static struct kfd_process *create_process(const struct task_struct *thread) 
	}

	BUG_ON(mn != &process->mmu_notifier);



	kfd_unref_process(process);

	get_task_struct(process->lead_thread);



	return process;