Commit 054d5575 authored by Louis Peens's avatar Louis Peens Committed by Jakub Kicinski
Browse files

net/sched: fix incorrect vlan_push_eth dest field 



Seems like a potential copy-paste bug slipped in here,
the second memcpy should of course be populating src
and not dest.

Fixes: ab95465c ("net/sched: add vlan push_eth and pop_eth action to the hardware IR")
Signed-off-by: default avatarLouis Peens <louis.peens@corigine.com>
Link: https://lore.kernel.org/r/20220323092506.21639-1-louis.peens@corigine.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a911ad18

include/net/tc_act/tc_vlan.h

+1 −1
Original line number Diff line number Diff line
@@ -84,7 +84,7 @@ static inline void tcf_vlan_push_eth(unsigned char *src, unsigned char *dest, 
{

	rcu_read_lock();

	memcpy(dest, rcu_dereference(to_vlan(a)->vlan_p)->tcfv_push_dst, ETH_ALEN);

	memcpy(dest, rcu_dereference(to_vlan(a)->vlan_p)->tcfv_push_src, ETH_ALEN);

	memcpy(src, rcu_dereference(to_vlan(a)->vlan_p)->tcfv_push_src, ETH_ALEN);

	rcu_read_unlock();

}