Commit 054b5580 authored by Balamurugan S's avatar Balamurugan S Committed by Kalle Valo
Browse files

wifi: ath12k: Avoid NULL pointer access during management transmit cleanup 



Currently 'ar' reference is not added in skb_cb.
Though this is generally not used during transmit completion
callbacks, on interface removal the remaining idr cleanup callback
uses the ar pointer from skb_cb from management txmgmt_idr. Hence fill them
during transmit call for proper usage to avoid NULL pointer dereference.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1

Signed-off-by: default avatarBalamurugan S <quic_bselvara@quicinc.com>
Signed-off-by: default avatarKalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230518071046.14337-1-quic_bselvara@quicinc.com
parent 37fdb33c

drivers/net/wireless/ath/ath12k/mac.c

+1 −0
Original line number Diff line number Diff line
@@ -4443,6 +4443,7 @@ static int ath12k_mac_mgmt_tx_wmi(struct ath12k *ar, struct ath12k_vif *arvif, 
	int buf_id;

	int ret;



	ATH12K_SKB_CB(skb)->ar = ar;

	spin_lock_bh(&ar->txmgmt_idr_lock);

	buf_id = idr_alloc(&ar->txmgmt_idr, skb, 0,

			   ATH12K_TX_MGMT_NUM_PENDING_MAX, GFP_ATOMIC);