Commit 0537f0a2 authored by D. Wythe's avatar D. Wythe Committed by David S. Miller
Browse files

net/smc: fix unexpected SMC_CLC_DECL_ERR_REGRMB error generated by client 



The main reason for this unexpected SMC_CLC_DECL_ERR_REGRMB in client
dues to following execution sequence:

Server Conn A:           Server Conn B:			Client Conn B:

smc_lgr_unregister_conn
                        smc_lgr_register_conn
                        smc_clc_send_accept     ->
                                                        smc_rtoken_add
smcr_buf_unuse
		->		Client Conn A:
				smc_rtoken_delete

smc_lgr_unregister_conn() makes current link available to assigned to new
incoming connection, while smcr_buf_unuse() has not executed yet, which
means that smc_rtoken_add may fail because of insufficient rtoken_entry,
reversing their execution order will avoid this problem.

Fixes: 3e034725 ("net/smc: common functions for RMBs and send buffers")
Signed-off-by: default avatarD. Wythe <alibuda@linux.alibaba.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent bd6f1fd5

net/smc/smc_core.c

+1 −1
Original line number Diff line number Diff line
@@ -1161,8 +1161,8 @@ void smc_conn_free(struct smc_connection *conn) 
			cancel_work_sync(&conn->abort_work);

	}

	if (!list_empty(&lgr->list)) {

		smc_lgr_unregister_conn(conn);

		smc_buf_unuse(conn, lgr); /* allow buffer reuse */

		smc_lgr_unregister_conn(conn);

	}



	if (!lgr->conns_num)