Commit 05332606 authored by Alexandru Ardelean's avatar Alexandru Ardelean Committed by Bartosz Golaszewski
Browse files

gpio: wm8350: remove platform_set_drvdata() + cleanup probe 



The platform_set_drvdata() call is only useful if we need to retrieve back
the private information.
Since the driver doesn't do that, it's not useful to have it.

If this is removed, we can also just do a direct return on
devm_gpiochip_add_data(). We don't need to print that this call failed as
there are other ways to log/see this during probe.

Signed-off-by: default avatarAlexandru Ardelean <aardelean@deviqon.com>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent e076aeda

drivers/gpio/gpio-wm8350.c

+1 −11
Original line number Diff line number Diff line
@@ -105,7 +105,6 @@ static int wm8350_gpio_probe(struct platform_device *pdev) 
	struct wm8350 *wm8350 = dev_get_drvdata(pdev->dev.parent);

	struct wm8350_platform_data *pdata = dev_get_platdata(wm8350->dev);

	struct wm8350_gpio_data *wm8350_gpio;

	int ret;



	wm8350_gpio = devm_kzalloc(&pdev->dev, sizeof(*wm8350_gpio),

				   GFP_KERNEL);
@@ -121,16 +120,7 @@ static int wm8350_gpio_probe(struct platform_device *pdev) 
	else

		wm8350_gpio->gpio_chip.base = -1;



	ret = devm_gpiochip_add_data(&pdev->dev, &wm8350_gpio->gpio_chip,

				     wm8350_gpio);

	if (ret < 0) {

		dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);

		return ret;

	}



	platform_set_drvdata(pdev, wm8350_gpio);



	return ret;

	return devm_gpiochip_add_data(&pdev->dev, &wm8350_gpio->gpio_chip, wm8350_gpio);

}



static struct platform_driver wm8350_gpio_driver = {