Commit 05311ce9 authored by Maxim Levitsky's avatar Maxim Levitsky Committed by Paolo Bonzini
Browse files

KVM: x86: remove exit_int_info warning in svm_handle_exit 



It is valid to receive external interrupt and have broken IDT entry,
which will lead to #GP with exit_int_into that will contain the index of
the IDT entry (e.g any value).

Other exceptions can happen as well, like #NP or #SS
(if stack switch fails).

Thus this warning can be user triggred and has very little value.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarMaxim Levitsky <mlevitsk@redhat.com>
Message-Id: <20221103141351.50662-10-mlevitsk@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 8357b9e1

arch/x86/kvm/svm/svm.c

+0 −15
Original line number Diff line number Diff line
@@ -346,12 +346,6 @@ int svm_set_efer(struct kvm_vcpu *vcpu, u64 efer) 
	return 0;

}



static int is_external_interrupt(u32 info)

{

	info &= SVM_EVTINJ_TYPE_MASK | SVM_EVTINJ_VALID;

	return info == (SVM_EVTINJ_VALID | SVM_EVTINJ_TYPE_INTR);

}



static u32 svm_get_interrupt_shadow(struct kvm_vcpu *vcpu)

{

	struct vcpu_svm *svm = to_svm(vcpu);
@@ -3426,15 +3420,6 @@ static int svm_handle_exit(struct kvm_vcpu *vcpu, fastpath_t exit_fastpath) 
		return 0;

	}



	if (is_external_interrupt(svm->vmcb->control.exit_int_info) &&

	    exit_code != SVM_EXIT_EXCP_BASE + PF_VECTOR &&

	    exit_code != SVM_EXIT_NPF && exit_code != SVM_EXIT_TASK_SWITCH &&

	    exit_code != SVM_EXIT_INTR && exit_code != SVM_EXIT_NMI)

		printk(KERN_ERR "%s: unexpected exit_int_info 0x%x "

		       "exit_code 0x%x\n",

		       __func__, svm->vmcb->control.exit_int_info,

		       exit_code);



	if (exit_fastpath != EXIT_FASTPATH_NONE)

		return 1;