Commit 0508c1ad authored by Wei Yongjun's avatar Wei Yongjun Committed by Gao Xiang
Browse files

erofs: fix error return code in erofs_read_superblock() 

'ret' will be overwritten to 0 if erofs_sb_has_sb_chksum() return true,
thus 0 will return in some error handling cases. Fix to return negative
error code -EINVAL instead of 0.

Link: https://lore.kernel.org/r/20210519141657.3062715-1-weiyongjun1@huawei.com


Fixes: b858a484 ("erofs: support superblock checksum")
Cc: stable <stable@vger.kernel.org> # 5.5+
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: default avatarGao Xiang <xiang@kernel.org>
Reviewed-by: default avatarChao Yu <yuchao0@huawei.com>
Signed-off-by: default avatarGao Xiang <xiang@kernel.org>
parent 614124be

fs/erofs/super.c

+1 −0
Original line number Diff line number Diff line
@@ -285,6 +285,7 @@ static int erofs_read_superblock(struct super_block *sb) 
			goto out;

	}



	ret = -EINVAL;

	blkszbits = dsb->blkszbits;

	/* 9(512 bytes) + LOG_SECTORS_PER_BLOCK == LOG_BLOCK_SIZE */

	if (blkszbits != LOG_BLOCK_SIZE) {