Commit 046cd8a2 authored by Hangyu Hua's avatar Hangyu Hua Committed by Rodrigo Vivi
Browse files

drm/i915: fix a possible refcount leak in intel_dp_add_mst_connector() 



If drm_connector_init fails, intel_connector_free will be called to take
care of proper free. So it is necessary to drop the refcount of port
before intel_connector_free.

Fixes: 091a4f91 ("drm/i915: Handle drm-layer errors in intel_dp_add_mst_connector")
Signed-off-by: default avatarHangyu Hua <hbh25y@gmail.com>
Reviewed-by: default avatarJosé Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220624130406.17996-1-jose.souza@intel.com


Signed-off-by: default avatarJosé Roberto de Souza <jose.souza@intel.com>
(cherry picked from commit cea9ed61)
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 32346491

drivers/gpu/drm/i915/display/intel_dp_mst.c

+1 −0
Original line number Diff line number Diff line
@@ -839,6 +839,7 @@ static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topolo 
	ret = drm_connector_init(dev, connector, &intel_dp_mst_connector_funcs,

				 DRM_MODE_CONNECTOR_DisplayPort);

	if (ret) {

		drm_dp_mst_put_port_malloc(port);

		intel_connector_free(intel_connector);

		return NULL;

	}