Commit 0460ce22 authored by Paolo Abeni's avatar Paolo Abeni Committed by David S. Miller
Browse files

mptcp: backup flag from incoming MPJ ack option 

the parsed incoming backup flag is not propagated
to the subflow itself, the client may end-up using it
to send data.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/191


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
Signed-off-by: default avatarMat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fc1b4e3b

net/mptcp/subflow.c

+4 −2
Original line number Diff line number Diff line
@@ -435,10 +435,12 @@ static void subflow_finish_connect(struct sock *sk, const struct sk_buff *skb) 
			goto do_reset;

		}



		subflow->backup = mp_opt.backup;

		subflow->thmac = mp_opt.thmac;

		subflow->remote_nonce = mp_opt.nonce;

		pr_debug("subflow=%p, thmac=%llu, remote_nonce=%u", subflow,

			 subflow->thmac, subflow->remote_nonce);

		pr_debug("subflow=%p, thmac=%llu, remote_nonce=%u backup=%d",

			 subflow, subflow->thmac, subflow->remote_nonce,

			 subflow->backup);



		if (!subflow_thmac_valid(subflow)) {

			MPTCP_INC_STATS(sock_net(sk), MPTCP_MIB_JOINACKMAC);