Commit 04499f28 authored by Lu Hongfei's avatar Lu Hongfei Committed by Paolo Abeni
Browse files

net: dsa: Removed unneeded of_node_put in felix_parse_ports_node 



Remove unnecessary of_node_put from the continue path to prevent
child node from being released twice, which could avoid resource
leak or other unexpected issues.

Signed-off-by: default avatarLu Hongfei <luhongfei@vivo.com>
Reviewed-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Fixes: de879a01 ("net: dsa: felix: add functionality when not all ports are supported")
Link: https://lore.kernel.org/r/20230710031859.36784-1-luhongfei@vivo.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent c0dbbdf5

drivers/net/dsa/ocelot/felix.c

+0 −1
Original line number Diff line number Diff line
@@ -1286,7 +1286,6 @@ static int felix_parse_ports_node(struct felix *felix, 
		if (err < 0) {

			dev_info(dev, "Unsupported PHY mode %s on port %d\n",

				 phy_modes(phy_mode), port);

			of_node_put(child);



			/* Leave port_phy_modes[port] = 0, which is also

			 * PHY_INTERFACE_MODE_NA. This will perform a