Commit 044012b5 authored by Stefan Mätje's avatar Stefan Mätje Committed by Marc Kleine-Budde
Browse files

can: usb: esd_usb2: esd_usb2_rx_event(): fix the interchange of the CAN RX and TX error counters 

This patch fixes the interchanged fetch of the CAN RX and TX error
counters from the ESD_EV_CAN_ERROR_EXT message. The RX error counter
is really in struct rx_msg::data[2] and the TX error counter is in
struct rx_msg::data[3].

Fixes: 96d8e903 ("can: Add driver for esd CAN-USB/2 device")
Link: https://lore.kernel.org/r/20210825215227.4947-2-stefan.maetje@esd.eu


Cc: stable@vger.kernel.org
Signed-off-by: default avatarStefan Mätje <stefan.maetje@esd.eu>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent ec92e524

drivers/net/can/usb/esd_usb2.c

+2 −2
Original line number Diff line number Diff line
@@ -224,8 +224,8 @@ static void esd_usb2_rx_event(struct esd_usb2_net_priv *priv, 
	if (id == ESD_EV_CAN_ERROR_EXT) {

		u8 state = msg->msg.rx.data[0];

		u8 ecc = msg->msg.rx.data[1];

		u8 txerr = msg->msg.rx.data[2];

		u8 rxerr = msg->msg.rx.data[3];

		u8 rxerr = msg->msg.rx.data[2];

		u8 txerr = msg->msg.rx.data[3];



		skb = alloc_can_err_skb(priv->netdev, &cf);

		if (skb == NULL) {