Commit 043d2acf authored by Pablo Neira Ayuso's avatar Pablo Neira Ayuso
Browse files

netfilter: nf_tables: drop module reference after updating chain 



Otherwise the module reference counter is leaked.

Fixes b9703ed4 ("netfilter: nf_tables: support for adding new devices to an existing netdev chain")
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent e26d3009

net/netfilter/nf_tables_api.c

+2 −0
Original line number Diff line number Diff line
@@ -2667,6 +2667,8 @@ static int nf_tables_updchain(struct nft_ctx *ctx, u8 genmask, u8 policy, 
	nft_trans_basechain(trans) = basechain;

	INIT_LIST_HEAD(&nft_trans_chain_hooks(trans));

	list_splice(&hook.list, &nft_trans_chain_hooks(trans));

	if (nla[NFTA_CHAIN_HOOK])

		module_put(hook.type->owner);



	nft_trans_commit_list_add_tail(ctx->net, trans);