Commit 043449e7 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki Committed by Hans de Goede
Browse files

platform: x86: ideapad-laptop: Use ACPI_COMPANION() directly 



The ACPI_HANDLE() macro is a wrapper arond the ACPI_COMPANION()
macro and the ACPI handle produced by the former comes from the
ACPI device object produced by the latter, so it is way more
straightforward to evaluate the latter directly instead of passing
the handle produced by the former to acpi_bus_get_device().

Modify ideapad_acpi_add() accordingly (no intentional functional
impact).

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://lore.kernel.org/r/8000884.T7Z3S40VBb@kreacher


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 7c7ba5de

drivers/platform/x86/ideapad-laptop.c

+2 −6
Original line number Diff line number Diff line
@@ -1555,17 +1555,13 @@ static void ideapad_check_features(struct ideapad_private *priv) 


static int ideapad_acpi_add(struct platform_device *pdev)

{

	struct acpi_device *adev = ACPI_COMPANION(&pdev->dev);

	struct ideapad_private *priv;

	struct acpi_device *adev;

	acpi_status status;

	unsigned long cfg;

	int err, i;



	err = acpi_bus_get_device(ACPI_HANDLE(&pdev->dev), &adev);

	if (err)

		return -ENODEV;



	if (eval_int(adev->handle, "_CFG", &cfg))

	if (!adev || eval_int(adev->handle, "_CFG", &cfg))

		return -ENODEV;



	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);