Commit 03f5eb30 authored by Randy Dunlap's avatar Randy Dunlap Committed by Hans de Goede
Browse files

platform: mellanox: select REGMAP instead of depending on it 



REGMAP is a hidden (not user visible) symbol. Users cannot set it
directly thru "make *config", so drivers should select it instead of
depending on it if they need it.

Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.

Therefore, change the use of "depends on REGMAP" to "select REGMAP".

For NVSW_SN2201, select REGMAP_I2C instead of depending on it.

Fixes: c6acad68 ("platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface")
Fixes: 5ec4a8ac ("platform/mellanox: Introduce support for Mellanox register access driver")
Fixes: 62f9529b ("platform/mellanox: mlxreg-lc: Add initial support for Nvidia line card devices")
Fixes: 662f2482 ("platform/mellanox: Add support for new SN2201 system")
Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Cc: Darren Hart <dvhart@infradead.org>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Michael Shych <michaelsh@nvidia.com>
Cc: Mark Gross <markgross@kernel.org>
Cc: Vadim Pasternak <vadimp@nvidia.com>
Cc: platform-driver-x86@vger.kernel.org
Link: https://lore.kernel.org/r/20230226053953.4681-6-rdunlap@infradead.org


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 6a192c0c

drivers/platform/mellanox/Kconfig

+4 −5
Original line number Diff line number Diff line
@@ -16,17 +16,17 @@ if MELLANOX_PLATFORM 


config MLXREG_HOTPLUG

	tristate "Mellanox platform hotplug driver support"

	depends on REGMAP

	depends on HWMON

	depends on I2C

	select REGMAP

	help

	  This driver handles hot-plug events for the power suppliers, power

	  cables and fans on the wide range Mellanox IB and Ethernet systems.



config MLXREG_IO

	tristate "Mellanox platform register access driver support"

	depends on REGMAP

	depends on HWMON

	select REGMAP

	help

	  This driver allows access to Mellanox programmable device register

	  space through sysfs interface. The sets of registers for sysfs access
@@ -36,9 +36,9 @@ config MLXREG_IO 


config MLXREG_LC

	tristate "Mellanox line card platform driver support"

	depends on REGMAP

	depends on HWMON

	depends on I2C

	select REGMAP

	help

	  This driver provides support for the Mellanox MSN4800-XX line cards,

	  which are the part of MSN4800 Ethernet modular switch systems
@@ -80,10 +80,9 @@ config MLXBF_PMC 


config NVSW_SN2201

	tristate "Nvidia SN2201 platform driver support"

	depends on REGMAP

	depends on HWMON

	depends on I2C

	depends on REGMAP_I2C

	select REGMAP_I2C

	help

	  This driver provides support for the Nvidia SN2201 platform.

	  The SN2201 is a highly integrated for one rack unit system with