Unverified Commit 03d68844 authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!5891 Fix several compilation warnings for hinic driver 

Merge Pull Request from: @ci-robot 
 
PR sync from: Zhou Shuai <zhoushuai28@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/VJCX4HRWSQK4N65ALL6RPNJF2YR3NRCY/ 
Compiling with GCC 12.3.1(openEuler 12.3.1-19.oe2403) using defconfig generates
a number of "Comparison always evaluates to True" warnings in hinic_hwdev.c.

Zhou Shuai (1):
  net/hinic: Fix several compilation warnings with
    aarch64-openEuler-linux toolchain


-- 
2.24.0
 
https://gitee.com/openeuler/kernel/issues/I9FAIF?from=project-issue 
 
Link:https://gitee.com/openeuler/kernel/pulls/5891

 

Reviewed-by: default avatarYue Haibing <yuehaibing@huawei.com>
Reviewed-by: default avatarChiqijun <chiqijun@huawei.com>
Signed-off-by: default avatarZheng Zengkai <zhengzengkai@huawei.com>
parents 5b8f1482 8ee689f8

drivers/net/ethernet/huawei/hinic/hinic_hwdev.c

+0 −6
Original line number Diff line number Diff line
@@ -3716,9 +3716,6 @@ static void port_sfp_info_event(struct hinic_hwdev *hwdev, void *buf_in, 
		return;

	}



	if (!chip_node->rt_cmd)

		return;



	rt_cmd = &chip_node->rt_cmd[sfp_info->port_id];

	mutex_lock(&chip_node->sfp_mutex);

	memcpy(&rt_cmd->sfp_info, sfp_info, sizeof(rt_cmd->sfp_info));
@@ -3745,9 +3742,6 @@ static void port_sfp_abs_event(struct hinic_hwdev *hwdev, void *buf_in, 
		return;

	}



	if (!chip_node->rt_cmd)

		return;



	rt_cmd = &chip_node->rt_cmd[sfp_abs->port_id];

	mutex_lock(&chip_node->sfp_mutex);

	memcpy(&rt_cmd->abs, sfp_abs, sizeof(rt_cmd->abs));