Commit 03b3d6be authored by Jens Axboe's avatar Jens Axboe
Browse files

io_uring/uring_cmd: ensure that device supports IOPOLL 

It's possible for a file type to support uring commands, but not
pollable ones. Hence before issuing one of those, we should check
that it is supported and error out upfront if it isn't.

Cc: stable@vger.kernel.org
Fixes: 5756a3a7 ("io_uring: add iopoll infrastructure for io_uring_cmd")
Link: https://github.com/axboe/liburing/issues/816


Reviewed-by: default avatarKanchan Joshi <joshi.k@samsung.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 01e68ce0

io_uring/uring_cmd.c

+3 −1
Original line number Diff line number Diff line
@@ -108,7 +108,7 @@ int io_uring_cmd(struct io_kiocb *req, unsigned int issue_flags) 
	struct file *file = req->file;

	int ret;



	if (!req->file->f_op->uring_cmd)

	if (!file->f_op->uring_cmd)

		return -EOPNOTSUPP;



	ret = security_uring_cmd(ioucmd);
@@ -120,6 +120,8 @@ int io_uring_cmd(struct io_kiocb *req, unsigned int issue_flags) 
	if (ctx->flags & IORING_SETUP_CQE32)

		issue_flags |= IO_URING_F_CQE32;

	if (ctx->flags & IORING_SETUP_IOPOLL) {

		if (!file->f_op->uring_cmd_iopoll)

			return -EOPNOTSUPP;

		issue_flags |= IO_URING_F_IOPOLL;

		req->iopoll_completed = 0;

		WRITE_ONCE(ioucmd->cookie, NULL);