Commit 03b123de authored by Eric Dumazet's avatar Eric Dumazet Committed by Jakub Kicinski
Browse files

tcp: tcp_enter_quickack_mode() should be static 



After commit d2ccd7bc ("tcp: avoid resetting ACK timer in DCTCP"),
tcp_enter_quickack_mode() is only used from net/ipv4/tcp_input.c.

Fixes: d2ccd7bc ("tcp: avoid resetting ACK timer in DCTCP")
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Yuchung Cheng <ycheng@google.com>
Cc: Neal Cardwell <ncardwell@google.com>
Link: https://lore.kernel.org/r/20230718162049.1444938-1-edumazet@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 730b9051

include/net/tcp.h

+0 −1
Original line number Diff line number Diff line
@@ -350,7 +350,6 @@ ssize_t tcp_splice_read(struct socket *sk, loff_t *ppos, 
struct sk_buff *tcp_stream_alloc_skb(struct sock *sk, gfp_t gfp,

				     bool force_schedule);



void tcp_enter_quickack_mode(struct sock *sk, unsigned int max_quickacks);

static inline void tcp_dec_quickack_mode(struct sock *sk,

					 const unsigned int pkts)

{

net/ipv4/tcp_input.c

+1 −2
Original line number Diff line number Diff line
@@ -297,7 +297,7 @@ static void tcp_incr_quickack(struct sock *sk, unsigned int max_quickacks) 
		icsk->icsk_ack.quick = quickacks;

}



void tcp_enter_quickack_mode(struct sock *sk, unsigned int max_quickacks)

static void tcp_enter_quickack_mode(struct sock *sk, unsigned int max_quickacks)

{

	struct inet_connection_sock *icsk = inet_csk(sk);
@@ -305,7 +305,6 @@ void tcp_enter_quickack_mode(struct sock *sk, unsigned int max_quickacks) 
	inet_csk_exit_pingpong_mode(sk);

	icsk->icsk_ack.ato = TCP_ATO_MIN;

}

EXPORT_SYMBOL(tcp_enter_quickack_mode);



/* Send ACKs quickly, if "quick" count is not exhausted

 * and the session is not interactive.