Commit 038fcdaf authored by Wang Qing's avatar Wang Qing Committed by David S. Miller
Browse files

net: ethernet: cavium: use div64_u64() instead of do_div() 



do_div() does a 64-by-32 division.
When the divisor is u64, do_div() truncates it to 32 bits, this means it
can test non-zero and be truncated to zero for division.

fix do_div.cocci warning:
do_div() does a 64-by-32 division, please consider using div64_u64 instead.

Signed-off-by: default avatarWang Qing <wangqing@vivo.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 237d20c2

drivers/net/ethernet/cavium/liquidio/lio_main.c

+2 −2
Original line number Diff line number Diff line
@@ -1539,7 +1539,7 @@ static int liquidio_ptp_adjfreq(struct ptp_clock_info *ptp, s32 ppb) 
	 * compute the delta in terms of coprocessor clocks.

	 */

	delta = (u64)ppb << 32;

	do_div(delta, oct->coproc_clock_rate);

	div64_u64(delta, oct->coproc_clock_rate);



	spin_lock_irqsave(&lio->ptp_lock, flags);

	comp = lio_pci_readq(oct, CN6XXX_MIO_PTP_CLOCK_COMP);
@@ -1672,7 +1672,7 @@ static void liquidio_ptp_init(struct octeon_device *oct) 
	u64 clock_comp, cfg;



	clock_comp = (u64)NSEC_PER_SEC << 32;

	do_div(clock_comp, oct->coproc_clock_rate);

	div64_u64(clock_comp, oct->coproc_clock_rate);

	lio_pci_writeq(oct, clock_comp, CN6XXX_MIO_PTP_CLOCK_COMP);



	/* Enable */