Commit 038b8d1d authored by Ilya Dryomov's avatar Ilya Dryomov
Browse files

libceph: optionally use bounce buffer on recv path in crc mode 

Both msgr1 and msgr2 in crc mode are zero copy in the sense that
message data is read from the socket directly into the destination
buffer.  We assume that the destination buffer is stable (i.e. remains
unchanged while it is being read to) though.  Otherwise, CRC errors
ensue:

  libceph: read_partial_message 0000000048edf8ad data crc 1063286393 != exp. 228122706
  libceph: osd1 (1)192.168.122.1:6843 bad crc/signature

  libceph: bad data crc, calculated 57958023, expected 1805382778
  libceph: osd2 (2)192.168.122.1:6876 integrity error, bad crc

Introduce rxbounce option to enable use of a bounce buffer when
receiving message data.  In particular this is needed if a mapped
image is a Windows VM disk, passed to QEMU.  Windows has a system-wide
"dummy" page that may be mapped into the destination buffer (potentially
more than once into the same buffer) by the Windows Memory Manager in
an effort to generate a single large I/O [1][2].  QEMU makes a point of
preserving overlap relationships when cloning I/O vectors, so krbd gets
exposed to this behaviour.

[1] "What Is Really in That MDL?"
    https://docs.microsoft.com/en-us/previous-versions/windows/hardware/design/dn614012(v=vs.85)
[2] https://blogs.msmvps.com/kernelmustard/2005/05/04/dummy-pages/

URL: https://bugzilla.redhat.com/show_bug.cgi?id=1973317


Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
parent 2ea88716

include/linux/ceph/libceph.h

+1 −0
Original line number Diff line number Diff line
@@ -35,6 +35,7 @@ 
#define CEPH_OPT_TCP_NODELAY      (1<<4) /* TCP_NODELAY on TCP sockets */

#define CEPH_OPT_NOMSGSIGN        (1<<5) /* don't sign msgs (msgr1) */

#define CEPH_OPT_ABORT_ON_FULL    (1<<6) /* abort w/ ENOSPC when full */

#define CEPH_OPT_RXBOUNCE         (1<<7) /* double-buffer read data */



#define CEPH_OPT_DEFAULT   (CEPH_OPT_TCP_NODELAY)

include/linux/ceph/messenger.h

+1 −0
Original line number Diff line number Diff line
@@ -461,6 +461,7 @@ struct ceph_connection { 
	struct ceph_msg *out_msg;        /* sending message (== tail of

					    out_sent) */



	struct page *bounce_page;

	u32 in_front_crc, in_middle_crc, in_data_crc;  /* calculated crc */



	struct timespec64 last_keepalive_ack; /* keepalive2 ack stamp */

net/ceph/ceph_common.c

+7 −0
Original line number Diff line number Diff line
@@ -246,6 +246,7 @@ enum { 
	Opt_cephx_sign_messages,

	Opt_tcp_nodelay,

	Opt_abort_on_full,

	Opt_rxbounce,

};



enum {
@@ -295,6 +296,7 @@ static const struct fs_parameter_spec ceph_parameters[] = { 
	fsparam_u32	("osdkeepalive",		Opt_osdkeepalivetimeout),

	fsparam_enum	("read_from_replica",		Opt_read_from_replica,

			 ceph_param_read_from_replica),

	fsparam_flag	("rxbounce",			Opt_rxbounce),

	fsparam_enum	("ms_mode",			Opt_ms_mode,

			 ceph_param_ms_mode),

	fsparam_string	("secret",			Opt_secret),
@@ -584,6 +586,9 @@ int ceph_parse_param(struct fs_parameter *param, struct ceph_options *opt, 
	case Opt_abort_on_full:

		opt->flags |= CEPH_OPT_ABORT_ON_FULL;

		break;

	case Opt_rxbounce:

		opt->flags |= CEPH_OPT_RXBOUNCE;

		break;



	default:

		BUG();
@@ -660,6 +665,8 @@ int ceph_print_client_options(struct seq_file *m, struct ceph_client *client, 
		seq_puts(m, "notcp_nodelay,");

	if (show_all && (opt->flags & CEPH_OPT_ABORT_ON_FULL))

		seq_puts(m, "abort_on_full,");

	if (opt->flags & CEPH_OPT_RXBOUNCE)

		seq_puts(m, "rxbounce,");



	if (opt->mount_timeout != CEPH_MOUNT_TIMEOUT_DEFAULT)

		seq_printf(m, "mount_timeout=%d,",

net/ceph/messenger.c

+4 −0
Original line number Diff line number Diff line
@@ -515,6 +515,10 @@ static void ceph_con_reset_protocol(struct ceph_connection *con) 
		ceph_msg_put(con->out_msg);

		con->out_msg = NULL;

	}

	if (con->bounce_page) {

		__free_page(con->bounce_page);

		con->bounce_page = NULL;

	}



	if (ceph_msgr2(from_msgr(con->msgr)))

		ceph_con_v2_reset_protocol(con);

net/ceph/messenger_v1.c

+48 −6
Original line number Diff line number Diff line
@@ -992,8 +992,7 @@ static int read_partial_message_section(struct ceph_connection *con, 


static int read_partial_msg_data(struct ceph_connection *con)

{

	struct ceph_msg *msg = con->in_msg;

	struct ceph_msg_data_cursor *cursor = &msg->cursor;

	struct ceph_msg_data_cursor *cursor = &con->in_msg->cursor;

	bool do_datacrc = !ceph_test_opt(from_msgr(con->msgr), NOCRC);

	struct page *page;

	size_t page_offset;
@@ -1001,9 +1000,6 @@ static int read_partial_msg_data(struct ceph_connection *con) 
	u32 crc = 0;

	int ret;



	if (!msg->num_data_items)

		return -EIO;



	if (do_datacrc)

		crc = con->in_data_crc;

	while (cursor->total_resid) {
@@ -1031,6 +1027,46 @@ static int read_partial_msg_data(struct ceph_connection *con) 
	return 1;	/* must return > 0 to indicate success */

}



static int read_partial_msg_data_bounce(struct ceph_connection *con)

{

	struct ceph_msg_data_cursor *cursor = &con->in_msg->cursor;

	struct page *page;

	size_t off, len;

	u32 crc;

	int ret;



	if (unlikely(!con->bounce_page)) {

		con->bounce_page = alloc_page(GFP_NOIO);

		if (!con->bounce_page) {

			pr_err("failed to allocate bounce page\n");

			return -ENOMEM;

		}

	}



	crc = con->in_data_crc;

	while (cursor->total_resid) {

		if (!cursor->resid) {

			ceph_msg_data_advance(cursor, 0);

			continue;

		}



		page = ceph_msg_data_next(cursor, &off, &len, NULL);

		ret = ceph_tcp_recvpage(con->sock, con->bounce_page, 0, len);

		if (ret <= 0) {

			con->in_data_crc = crc;

			return ret;

		}



		crc = crc32c(crc, page_address(con->bounce_page), ret);

		memcpy_to_page(page, off, page_address(con->bounce_page), ret);



		ceph_msg_data_advance(cursor, ret);

	}

	con->in_data_crc = crc;



	return 1;	/* must return > 0 to indicate success */

}



/*

 * read (part of) a message.

 */
@@ -1141,6 +1177,12 @@ static int read_partial_message(struct ceph_connection *con) 


	/* (page) data */

	if (data_len) {

		if (!m->num_data_items)

			return -EIO;



		if (ceph_test_opt(from_msgr(con->msgr), RXBOUNCE))

			ret = read_partial_msg_data_bounce(con);

		else

			ret = read_partial_msg_data(con);

		if (ret <= 0)

			return ret;