Commit 037697dd authored by Crt Mori's avatar Crt Mori Committed by Jonathan Cameron
Browse files

iio:temperature:mlx90632: Convert polling while loop to regmap 



Reduce number of lines and improve readability to convert polling while
loops to regmap_read_poll_timeout.

Signed-off-by: default avatarCrt Mori <cmo@melexis.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20200818213737.140613-4-cmo@melexis.com


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 856437db

drivers/iio/temperature/mlx90632.c

+5 −11
Original line number Diff line number Diff line
@@ -180,25 +180,19 @@ static s32 mlx90632_pwr_continuous(struct regmap *regmap) 
 */

static int mlx90632_perform_measurement(struct mlx90632_data *data)

{

	int ret, tries = 100;

	unsigned int reg_status;

	int ret;



	ret = regmap_update_bits(data->regmap, MLX90632_REG_STATUS,

				 MLX90632_STAT_DATA_RDY, 0);

	if (ret < 0)

		return ret;



	while (tries-- > 0) {

		ret = regmap_read(data->regmap, MLX90632_REG_STATUS,

				  &reg_status);

		if (ret < 0)

			return ret;

		if (reg_status & MLX90632_STAT_DATA_RDY)

			break;

		usleep_range(10000, 11000);

	}

	ret = regmap_read_poll_timeout(data->regmap, MLX90632_REG_STATUS, reg_status,

				       !(reg_status & MLX90632_STAT_DATA_RDY), 10000,

				       100 * 10000);



	if (tries < 0) {

	if (ret < 0) {

		dev_err(&data->client->dev, "data not ready");

		return -ETIMEDOUT;

	}