Commit 0352c3d3 authored by Roman Bolshakov's avatar Roman Bolshakov Committed by Martin K. Petersen
Browse files

scsi: target: iscsi: Fix zero tag inside a trace event 

target_sequencer_start event is triggered inside target_cmd_init_cdb().
se_cmd.tag is not initialized with ITT at the moment so the event always
prints zero tag.

Link: https://lore.kernel.org/r/20210403215415.95077-1-r.bolshakov@yadro.com


Cc: stable@vger.kernel.org # 5.10+
Reviewed-by: default avatarMike Christie <michael.christie@oracle.com>
Signed-off-by: default avatarRoman Bolshakov <r.bolshakov@yadro.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 65df7d19

drivers/target/iscsi/iscsi_target.c

+1 −2
Original line number Diff line number Diff line
@@ -1166,6 +1166,7 @@ int iscsit_setup_scsi_cmd(struct iscsi_conn *conn, struct iscsi_cmd *cmd, 


	target_get_sess_cmd(&cmd->se_cmd, true);



	cmd->se_cmd.tag = (__force u32)cmd->init_task_tag;

	cmd->sense_reason = target_cmd_init_cdb(&cmd->se_cmd, hdr->cdb);

	if (cmd->sense_reason) {

		if (cmd->sense_reason == TCM_OUT_OF_RESOURCES) {
@@ -1180,8 +1181,6 @@ int iscsit_setup_scsi_cmd(struct iscsi_conn *conn, struct iscsi_cmd *cmd, 
	if (cmd->sense_reason)

		goto attach_cmd;



	/* only used for printks or comparing with ->ref_task_tag */

	cmd->se_cmd.tag = (__force u32)cmd->init_task_tag;

	cmd->sense_reason = target_cmd_parse_cdb(&cmd->se_cmd);

	if (cmd->sense_reason)

		goto attach_cmd;