Commit 0336f8ff authored by Pavel Skripkin's avatar Pavel Skripkin Committed by David S. Miller
Browse files

net: ti: fix UAF in tlan_remove_one 



priv is netdev private data and it cannot be
used after free_netdev() call. Using priv after free_netdev()
can cause UAF bug. Fix it by moving free_netdev() at the end of the
function.

Fixes: 1e0a8b13 ("tlan: cancel work at remove path")
Signed-off-by: default avatarPavel Skripkin <paskripkin@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ad297cd2

drivers/net/ethernet/ti/tlan.c

+1 −2
Original line number Diff line number Diff line
@@ -313,9 +313,8 @@ static void tlan_remove_one(struct pci_dev *pdev) 
	pci_release_regions(pdev);

#endif



	free_netdev(dev);



	cancel_work_sync(&priv->tlan_tqueue);

	free_netdev(dev);

}



static void tlan_start(struct net_device *dev)