Commit 032062f3 authored by Jon Maloy's avatar Jon Maloy Committed by Jakub Kicinski
Browse files

tipc: fix wrong publisher node address in link publications 



When a link comes up we add its presence to the name table to make it
possible for users to subscribe for link up/down events. However, after
a previous call signature change the binding is wrongly published with
the peer node as publishing node, instead of the own node as it should
be. This has the effect that the command 'tipc name table show' will
list the link binding (service type 2) with node scope and a peer node
as originator, something that obviously is impossible.

We correct this bug here.

Fixes: 50a3499a ("tipc: simplify signature of tipc_namtbl_publish()")
Signed-off-by: default avatarJon Maloy <jmaloy@redhat.com>
Link: https://lore.kernel.org/r/20220214013852.2803940-1-jmaloy@redhat.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6605cc67

net/tipc/node.c

+1 −1
Original line number Diff line number Diff line
@@ -413,7 +413,7 @@ static void tipc_node_write_unlock(struct tipc_node *n) 
	tipc_uaddr(&ua, TIPC_SERVICE_RANGE, TIPC_NODE_SCOPE,

		   TIPC_LINK_STATE, n->addr, n->addr);

	sk.ref = n->link_id;

	sk.node = n->addr;

	sk.node = tipc_own_addr(net);

	bearer_id = n->link_id & 0xffff;

	publ_list = &n->publ_list;