Commit 031f2147 authored by Md Fahad Iqbal Polash's avatar Md Fahad Iqbal Polash Committed by Jeff Kirsher
Browse files

ice: Update Boot Configuration Section read of NVM 



The Boot Configuration Section Block has been moved to the Preserved Field
Area (PFA) of NVM. Update the NVM reads that involves Boot Configuration
Section.

Signed-off-by: default avatarMd Fahad Iqbal Polash <md.fahad.iqbal.polash@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent a012dca9

drivers/net/ethernet/intel/ice/ice_common.c

+66 −0
Original line number Diff line number Diff line
@@ -1066,6 +1066,72 @@ enum ice_status ice_reset(struct ice_hw *hw, enum ice_reset_req req) 
	return ice_check_reset(hw);

}



/**

 * ice_get_pfa_module_tlv - Reads sub module TLV from NVM PFA

 * @hw: pointer to hardware structure

 * @module_tlv: pointer to module TLV to return

 * @module_tlv_len: pointer to module TLV length to return

 * @module_type: module type requested

 *

 * Finds the requested sub module TLV type from the Preserved Field

 * Area (PFA) and returns the TLV pointer and length. The caller can

 * use these to read the variable length TLV value.

 */

enum ice_status

ice_get_pfa_module_tlv(struct ice_hw *hw, u16 *module_tlv, u16 *module_tlv_len,

		       u16 module_type)

{

	enum ice_status status;

	u16 pfa_len, pfa_ptr;

	u16 next_tlv;



	status = ice_read_sr_word(hw, ICE_SR_PFA_PTR, &pfa_ptr);

	if (status) {

		ice_debug(hw, ICE_DBG_INIT, "Preserved Field Array pointer.\n");

		return status;

	}

	status = ice_read_sr_word(hw, pfa_ptr, &pfa_len);

	if (status) {

		ice_debug(hw, ICE_DBG_INIT, "Failed to read PFA length.\n");

		return status;

	}

	/* Starting with first TLV after PFA length, iterate through the list

	 * of TLVs to find the requested one.

	 */

	next_tlv = pfa_ptr + 1;

	while (next_tlv < pfa_ptr + pfa_len) {

		u16 tlv_sub_module_type;

		u16 tlv_len;



		/* Read TLV type */

		status = ice_read_sr_word(hw, next_tlv, &tlv_sub_module_type);

		if (status) {

			ice_debug(hw, ICE_DBG_INIT, "Failed to read TLV type.\n");

			break;

		}

		/* Read TLV length */

		status = ice_read_sr_word(hw, next_tlv + 1, &tlv_len);

		if (status) {

			ice_debug(hw, ICE_DBG_INIT, "Failed to read TLV length.\n");

			break;

		}

		if (tlv_sub_module_type == module_type) {

			if (tlv_len) {

				*module_tlv = next_tlv;

				*module_tlv_len = tlv_len;

				return 0;

			}

			return ICE_ERR_INVAL_SIZE;

		}

		/* Check next TLV, i.e. current TLV pointer + length + 2 words

		 * (for current TLV's type and length)

		 */

		next_tlv = next_tlv + tlv_len + 2;

	}

	/* Module does not exist */

	return ICE_ERR_DOES_NOT_EXIST;

}



/**

 * ice_copy_rxq_ctx_to_hw

 * @hw: pointer to the hardware structure

drivers/net/ethernet/intel/ice/ice_common.h

+4 −0
Original line number Diff line number Diff line
@@ -6,6 +6,7 @@ 


#include "ice.h"

#include "ice_type.h"

#include "ice_nvm.h"

#include "ice_flex_pipe.h"

#include "ice_switch.h"

#include <linux/avf/virtchnl.h>
@@ -16,6 +17,9 @@ void 
ice_debug_cq(struct ice_hw *hw, u32 mask, void *desc, void *buf, u16 buf_len);

enum ice_status ice_init_hw(struct ice_hw *hw);

void ice_deinit_hw(struct ice_hw *hw);

enum ice_status

ice_get_pfa_module_tlv(struct ice_hw *hw, u16 *module_tlv, u16 *module_tlv_len,

		       u16 module_type);

enum ice_status ice_check_reset(struct ice_hw *hw);

enum ice_status ice_reset(struct ice_hw *hw, enum ice_reset_req req);

enum ice_status ice_create_all_ctrlq(struct ice_hw *hw);

drivers/net/ethernet/intel/ice/ice_nvm.c

+42 −9
Original line number Diff line number Diff line
@@ -219,8 +219,7 @@ static void ice_release_nvm(struct ice_hw *hw) 
 *

 * Reads one 16 bit word from the Shadow RAM using the ice_read_sr_word_aq.

 */

static enum ice_status

ice_read_sr_word(struct ice_hw *hw, u16 offset, u16 *data)

enum ice_status ice_read_sr_word(struct ice_hw *hw, u16 offset, u16 *data)

{

	enum ice_status status;
@@ -242,9 +241,10 @@ ice_read_sr_word(struct ice_hw *hw, u16 offset, u16 *data) 
 */

enum ice_status ice_init_nvm(struct ice_hw *hw)

{

	u16 oem_hi, oem_lo, boot_cfg_tlv, boot_cfg_tlv_len;

	struct ice_nvm_info *nvm = &hw->nvm;

	u16 eetrack_lo, eetrack_hi;

	enum ice_status status = 0;

	enum ice_status status;

	u32 fla, gens_stat;

	u8 sr_size;
@@ -261,15 +261,15 @@ enum ice_status ice_init_nvm(struct ice_hw *hw) 
	fla = rd32(hw, GLNVM_FLA);

	if (fla & GLNVM_FLA_LOCKED_M) { /* Normal programming mode */

		nvm->blank_nvm_mode = false;

	} else { /* Blank programming mode */

	} else {

		/* Blank programming mode */

		nvm->blank_nvm_mode = true;

		status = ICE_ERR_NVM_BLANK_MODE;

		ice_debug(hw, ICE_DBG_NVM,

			  "NVM init error: unsupported blank mode.\n");

		return status;

		return ICE_ERR_NVM_BLANK_MODE;

	}



	status = ice_read_sr_word(hw, ICE_SR_NVM_DEV_STARTER_VER, &hw->nvm.ver);

	status = ice_read_sr_word(hw, ICE_SR_NVM_DEV_STARTER_VER, &nvm->ver);

	if (status) {

		ice_debug(hw, ICE_DBG_INIT,

			  "Failed to read DEV starter version.\n");
@@ -287,11 +287,44 @@ enum ice_status ice_init_nvm(struct ice_hw *hw) 
		return status;

	}



	hw->nvm.eetrack = (eetrack_hi << 16) | eetrack_lo;

	nvm->eetrack = (eetrack_hi << 16) | eetrack_lo;



	status = ice_get_pfa_module_tlv(hw, &boot_cfg_tlv, &boot_cfg_tlv_len,

					ICE_SR_BOOT_CFG_PTR);

	if (status) {

		ice_debug(hw, ICE_DBG_INIT,

			  "Failed to read Boot Configuration Block TLV.\n");

		return status;

	}



	/* Boot Configuration Block must have length at least 2 words

	 * (Combo Image Version High and Combo Image Version Low)

	 */

	if (boot_cfg_tlv_len < 2) {

		ice_debug(hw, ICE_DBG_INIT,

			  "Invalid Boot Configuration Block TLV size.\n");

		return ICE_ERR_INVAL_SIZE;

	}



	status = ice_read_sr_word(hw, (boot_cfg_tlv + ICE_NVM_OEM_VER_OFF),

				  &oem_hi);

	if (status) {

		ice_debug(hw, ICE_DBG_INIT, "Failed to read OEM_VER hi.\n");

		return status;

	}



	status = ice_read_sr_word(hw, (boot_cfg_tlv + ICE_NVM_OEM_VER_OFF + 1),

				  &oem_lo);

	if (status) {

		ice_debug(hw, ICE_DBG_INIT, "Failed to read OEM_VER lo.\n");

		return status;

	}



	nvm->oem_ver = ((u32)oem_hi << 16) | oem_lo;



	return 0;

}



/**

 * ice_read_sr_buf - Reads Shadow RAM buf and acquire lock if necessary

 * @hw: pointer to the HW structure

drivers/net/ethernet/intel/ice/ice_nvm.h

0 → 100644
+8 −0
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0 */

/* Copyright (c) 2019, Intel Corporation. */



#ifndef _ICE_NVM_H_

#define _ICE_NVM_H_



enum ice_status ice_read_sr_word(struct ice_hw *hw, u16 offset, u16 *data);

#endif /* _ICE_NVM_H_ */

drivers/net/ethernet/intel/ice/ice_type.h

+3 −0
Original line number Diff line number Diff line
@@ -555,6 +555,8 @@ struct ice_hw_port_stats { 
};



/* Checksum and Shadow RAM pointers */

#define ICE_SR_BOOT_CFG_PTR		0x132

#define ICE_NVM_OEM_VER_OFF		0x02

#define ICE_SR_NVM_DEV_STARTER_VER	0x18

#define ICE_SR_NVM_EETRACK_LO		0x2D

#define ICE_SR_NVM_EETRACK_HI		0x2E
@@ -568,6 +570,7 @@ struct ice_hw_port_stats { 
#define ICE_OEM_VER_BUILD_MASK		(0xffff << ICE_OEM_VER_BUILD_SHIFT)

#define ICE_OEM_VER_SHIFT		24

#define ICE_OEM_VER_MASK		(0xff << ICE_OEM_VER_SHIFT)

#define ICE_SR_PFA_PTR			0x40

#define ICE_SR_SECTOR_SIZE_IN_WORDS	0x800

#define ICE_SR_WORDS_IN_1KB		512