Commit 03026197 authored by Jing Xiangfeng's avatar Jing Xiangfeng Committed by Greg Kroah-Hartman
Browse files

usb: typec: Add the missed altmode_id_remove() in typec_register_altmode() 



typec_register_altmode() misses to call altmode_id_remove() in an error
path. Add the missed function call to fix it.

Fixes: 8a37d87d ("usb: typec: Bus type for alternate modes")
Cc: stable <stable@vger.kernel.org>
Acked-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: default avatarJing Xiangfeng <jingxiangfeng@huawei.com>
Link: https://lore.kernel.org/r/20210617073226.47599-1-jingxiangfeng@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2b537cf8

drivers/usb/typec/class.c

+3 −1
Original line number Diff line number Diff line
@@ -517,8 +517,10 @@ typec_register_altmode(struct device *parent, 
	int ret;



	alt = kzalloc(sizeof(*alt), GFP_KERNEL);

	if (!alt)

	if (!alt) {

		altmode_id_remove(parent, id);

		return ERR_PTR(-ENOMEM);

	}



	alt->adev.svid = desc->svid;

	alt->adev.mode = desc->mode;