Commit 02fb0945 authored by Hans de Goede's avatar Hans de Goede
Browse files

platform/x86: x86-android-tablets: Fix GPIO lookup leak on error-exit 



Fix leaking the registered gpiod_lookup tables when the kcalloc() for the
i2c_clients array fails.

Fixes: ef2ac114 ("platform/x86: x86-android-tablets: Add support for registering GPIO lookup tables")
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20220108154947.136593-1-hdegoede@redhat.com
parent 62ac88a7

drivers/platform/x86/x86-android-tablets.c

+3 −1
Original line number Diff line number Diff line
@@ -815,8 +815,10 @@ static __init int x86_android_tablet_init(void) 
		gpiod_add_lookup_table(gpiod_lookup_tables[i]);



	i2c_clients = kcalloc(dev_info->i2c_client_count, sizeof(*i2c_clients), GFP_KERNEL);

	if (!i2c_clients)

	if (!i2c_clients) {

		x86_android_tablet_cleanup();

		return -ENOMEM;

	}



	i2c_client_count = dev_info->i2c_client_count;

	for (i = 0; i < i2c_client_count; i++) {