Unverified Commit 02ccdeed authored by Jisheng Zhang's avatar Jisheng Zhang Committed by Palmer Dabbelt
Browse files

riscv: kprobes: Fix build error when MMU=n 



lkp reported a randconfig failure:

arch/riscv/kernel/probes/kprobes.c:90:22: error: use of undeclared identifier 'PAGE_KERNEL_READ_EXEC'

We implemented the alloc_insn_page() to allocate PAGE_KERNEL_READ_EXEC
page for kprobes insn page for STRICT_MODULE_RWX. But if MMU=n, we
should fall back to the generic weak alloc_insn_page() by generic
kprobe subsystem.

Fixes: cdd1b2bd ("riscv: kprobes: Implement alloc_insn_page()")
Signed-off-by: default avatarJisheng Zhang <jszhang@kernel.org>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarPalmer Dabbelt <palmerdabbelt@google.com>
parent 97a03108

arch/riscv/kernel/probes/kprobes.c

+2 −0
Original line number Diff line number Diff line
@@ -84,6 +84,7 @@ int __kprobes arch_prepare_kprobe(struct kprobe *p) 
	return 0;

}



#ifdef CONFIG_MMU

void *alloc_insn_page(void)

{

	return  __vmalloc_node_range(PAGE_SIZE, 1, VMALLOC_START, VMALLOC_END,
@@ -91,6 +92,7 @@ void *alloc_insn_page(void) 
				     VM_FLUSH_RESET_PERMS, NUMA_NO_NODE,

				     __builtin_return_address(0));

}

#endif



/* install breakpoint in text */

void __kprobes arch_arm_kprobe(struct kprobe *p)