Commit 0299faea authored by Brett Creeley's avatar Brett Creeley Committed by Tony Nguyen
Browse files

ice: Remove toggling of antispoof for VF trusted promiscuous mode 



Currently when a trusted VF enables promiscuous mode spoofchk will be
disabled. This is wrong and should only be modified from the
ndo_set_vf_spoofchk callback. Fix this by removing the call to toggle
spoofchk for trusted VFs.

Fixes: 01b5e89a ("ice: Add VF promiscuous support")
Signed-off-by: default avatarBrett Creeley <brett.creeley@intel.com>
Tested-by: default avatarTony Brelinski <tony.brelinski@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 1a8c7778

drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c

+0 −18
Original line number Diff line number Diff line
@@ -3055,24 +3055,6 @@ static int ice_vc_cfg_promiscuous_mode_msg(struct ice_vf *vf, u8 *msg) 
	rm_promisc = !allmulti && !alluni;



	if (vsi->num_vlan || vf->port_vlan_info) {

		struct ice_vsi *pf_vsi = ice_get_main_vsi(pf);

		struct net_device *pf_netdev;



		if (!pf_vsi) {

			v_ret = VIRTCHNL_STATUS_ERR_PARAM;

			goto error_param;

		}



		pf_netdev = pf_vsi->netdev;



		ret = ice_set_vf_spoofchk(pf_netdev, vf->vf_id, rm_promisc);

		if (ret) {

			dev_err(dev, "Failed to update spoofchk to %s for VF %d VSI %d when setting promiscuous mode\n",

				rm_promisc ? "ON" : "OFF", vf->vf_id,

				vsi->vsi_num);

			v_ret = VIRTCHNL_STATUS_ERR_PARAM;

		}



		if (rm_promisc)

			ret = ice_cfg_vlan_pruning(vsi, true);

		else