Commit 02934071 authored by Junhao He's avatar Junhao He Committed by JiangShui
Browse files

coresight: ultrasoc-smb: Fix uninitialized before use buf_hw_base 

maillist inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I8ICOU
CVE: NA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git/commit/?h=fixes&id=862c135bde8bc185e8aae2110374175e6a1b6ed5



---------------------------------------------------------------------------

In smb_reset_buffer, the sdb->buf_hw_base variable is uninitialized
before use, which initializes it in smb_init_data_buffer. And the SMB
regiester are set in smb_config_inport.
So move the call after smb_config_inport.

Fixes: 06f5c292 ("drivers/coresight: Add UltraSoc System Memory Buffer driver")
Signed-off-by: default avatarJunhao He <hejunhao3@huawei.com>
Reviewed-by: default avatarJames Clark <james.clark@arm.com>
Signed-off-by: default avatarSuzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: default avatarCai Jian <caijian11@h-partners.com>
Link: https://lore.kernel.org/r/20231114133346.30489-4-hejunhao3@huawei.com
parent d558ecbc

drivers/hwtracing/coresight/ultrasoc-smb.c

+1 −1
Original line number Diff line number Diff line
@@ -476,7 +476,6 @@ static int smb_init_data_buffer(struct platform_device *pdev, 
static void smb_init_hw(struct smb_drv_data *drvdata)

{

	smb_disable_hw(drvdata);

	smb_reset_buffer(drvdata);



	writel(SMB_LB_CFG_LO_DEFAULT, drvdata->base + SMB_LB_CFG_LO_REG);

	writel(SMB_LB_CFG_HI_DEFAULT, drvdata->base + SMB_LB_CFG_HI_REG);
@@ -586,6 +585,7 @@ static int smb_probe(struct platform_device *pdev) 
	if (ret)

		return ret;



	smb_reset_buffer(drvdata);

	platform_set_drvdata(pdev, drvdata);

	spin_lock_init(&drvdata->spinlock);

	drvdata->pid = -1;