Commit 0288e7fa authored by Hui Su's avatar Hui Su Committed by Greg Kroah-Hartman
Browse files

fs/kernfs: remove the double check of dentry->inode 



In both kernfs_node_from_dentry() and in
kernfs_dentry_node(), we will check the dentry->inode
is NULL or not, which is superfluous.

So remove the check in kernfs_node_from_dentry().

Acked-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarHui Su <sh_def@163.com>
Link: https://lore.kernel.org/r/20201113132143.GA119541@rlk


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 784b2c48

fs/kernfs/dir.c

+1 −2
Original line number Diff line number Diff line
@@ -604,8 +604,7 @@ const struct dentry_operations kernfs_dops = { 
 */

struct kernfs_node *kernfs_node_from_dentry(struct dentry *dentry)

{

	if (dentry->d_sb->s_op == &kernfs_sops &&

	    !d_really_is_negative(dentry))

	if (dentry->d_sb->s_op == &kernfs_sops)

		return kernfs_dentry_node(dentry);

	return NULL;

}