Commit 027d53b0 authored by Ofir Bitton's avatar Ofir Bitton Committed by Oded Gabbay
Browse files

habanalabs: remove redundant cs validity checks 



During TDR handling, we check multiple times if CS is valid.
No need to perform this check as CS must be valid at all time
during the TDR handling.

Signed-off-by: default avatarOfir Bitton <obitton@habana.ai>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 2b28485d

drivers/misc/habanalabs/common/command_submission.c

+2 −3
Original line number Diff line number Diff line
@@ -431,11 +431,10 @@ static void cs_handle_tdr(struct hl_device *hdev, struct hl_cs *cs) 
	/* Don't cancel TDR in case this CS was timedout because we might be

	 * running from the TDR context

	 */

	if (cs && (cs->timedout ||

			hdev->timeout_jiffies == MAX_SCHEDULE_TIMEOUT))

	if (cs->timedout || hdev->timeout_jiffies == MAX_SCHEDULE_TIMEOUT)

		return;



	if (cs && cs->tdr_active)

	if (cs->tdr_active)

		cancel_delayed_work_sync(&cs->work_tdr);



	spin_lock(&hdev->cs_mirror_lock);