Commit 027cf316 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jan Kara
Browse files

afs: remove manual O_SYNC handling 



generic_file_aio_write already calls into ->fsync to handle O_SYNC/O_DSYNC.
Remove the duplicate manual invocation.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent 94004ed7

fs/afs/write.c

+0 −9
Original line number Diff line number Diff line
@@ -671,7 +671,6 @@ ssize_t afs_file_write(struct kiocb *iocb, const struct iovec *iov, 
	struct afs_vnode *vnode = AFS_FS_I(dentry->d_inode);

	ssize_t result;

	size_t count = iov_length(iov, nr_segs);

	int ret;



	_enter("{%x.%u},{%zu},%lu,",

	       vnode->fid.vid, vnode->fid.vnode, count, nr_segs);
@@ -691,14 +690,6 @@ ssize_t afs_file_write(struct kiocb *iocb, const struct iovec *iov, 
		return result;

	}



	/* return error values for O_SYNC and IS_SYNC() */

	if (IS_SYNC(&vnode->vfs_inode) || iocb->ki_filp->f_flags & O_DSYNC) {

		ret = afs_fsync(iocb->ki_filp, dentry,

				(iocb->ki_filp->f_flags & __O_SYNC) ? 0 : 1);

		if (ret < 0)

			result = ret;

	}



	_leave(" = %zd", result);

	return result;

}